Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise useful error when waveform_id is incomplete #564

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

calum-chamberlain
Copy link
Member

See #563 - some picks from FDSN services are missing channel codes resulting in an opaque and hard to understand error.

What does this PR do?

Adds a useful error message when waveform_ids are incomplete when generating templates.

Why was it initiated? Any relevant Issues?

#563

PR Checklist

  • develop base branch selected?
  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGES.md.
  • First time contributors have added your name to CONTRIBUTORS.md.

See #563 - some picks from FDSN services are missing channel codes resulting in an opaque and hard to understand error.
@calum-chamberlain calum-chamberlain merged commit c5daf19 into develop Jun 28, 2024
18 of 20 checks passed
@calum-chamberlain calum-chamberlain deleted the waveform_id_error branch June 28, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant