fix(executor/estimate): fee estimation should fail for reverts #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aligns the behavior of starknet_estimateFee with starknet_simulateTransactions, ensuring that fee estimation fails for reverted transactions, while simulation continues to provide estimates and traces with revert reasons.
sistemd
reviewed
Feb 17, 2025
And use `Transaction::tx_hash()` instead.
And make it private.
Fee estimation and transaction simulation now uses a shared code path for execution -- but the expected behavior for a reverted transaction is different between the two. This commit makes the expected revert behavior explicit in the shared code path.
Base automatically changed from
krisztian/fix-rpc-call-failure-error-stack
to
main
February 18, 2025 08:09
sistemd
approved these changes
Feb 18, 2025
kkovaacs
deleted the
krisztian/rpc-fix-fee-estimation-for-reverted-txs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the behavior of
starknet_estimateFeewithstarknet_simulateTransactions, ensuring that fee estimation fails for reverted transactions, while simulation continues to provide estimates and traces with revert reasons.In the expected output for the test we can also see that our handling of
Cairo1RevertSummarywithin an error stack is suboptimal: instead of having the string representation in there we should properly convert the summary into multiple frames. I've created #2596 for that problem.