feat: support importing legacy snapshots #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zeapoz
commented
Aug 15, 2024
zeapoz
commented
- Adds support for importing V0 snapshots.
- Moves util functions to a separate crate so they can be used across all crates.
vbar
approved these changes
Aug 15, 2024
|
|
||
| pub const DEFAULT_DB_PATH: &str = "snapshot_db"; | ||
| pub const SNAPSHOT_HEADER_FILE_NAME: &str = "snapshot-header.json"; | ||
| pub const SNAPSHOT_HEADER_FILE_NAME: &str = "snapshot_header.json"; |
There was a problem hiding this comment.
why? I bet I'll confuse the name when following some old doc, sooner or later...
There was a problem hiding this comment.
Every other snapshot file name uses _ over - as a separator. I don't think we should deviate from that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.