Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(snapshots): use correct l1 batch number of initial write #115

Merged
merged 2 commits into from
Aug 22, 2024
Merged

chore(snapshots): use correct l1 batch number of initial write #115

merged 2 commits into from
Aug 22, 2024

Conversation

zeapoz
Copy link
Member

@zeapoz zeapoz commented Aug 21, 2024

No description provided.

@zeapoz zeapoz requested a review from vbar August 21, 2024 06:44
vbar
vbar approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@vbar vbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the obvious question: does it fix the snapshot recovery use case?

@zeapoz
Copy link
Member Author

zeapoz commented Aug 21, 2024

So, the obvious question: does it fix the snapshot recovery use case?

Hopefully it should, I'm generating a new snapshot right now. Once that completes I'll test it again

@zeapoz zeapoz merged commit b787de9 into main Aug 22, 2024
4 checks passed
@zeapoz zeapoz deleted the chore/snapshot-l1-batch-number-of-initial-write branch August 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbar vbar vbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeapoz @vbar