Add some metrics for L1 processing #29
Conversation
Prints total progress and number of processed blocks.
src/l1_fetcher.rs
Outdated
| let perc = (cur * 100) / total; | ||
| format!("{perc}%") | ||
| } | ||
| None => "∞".to_string(), |
There was a problem hiding this comment.
Currently this won't print any percentages if we don't supply an end_block, right? Could we use the latest (currently polled) L1 block number that exists in that case?
There was a problem hiding this comment.
this won't print any percentages if we don't supply an end_block, right?
If disable_polling == false, the execution continues forever and then this won't print any percentages.
Could we use the latest (currently polled) L1 block number that exists in that case?
With extremely long stretch, yeah, maybe we could, but it would be very far from correct.
I struggled quite a bit to provide any useful metrics from L1 blocks because of following behaviour:
- We don't literally process L1 blocks. We filter event logs with certain criteria and each filter batch spans over multiple L1 blocks.
- We see events from L1 blocks here & there. Similar story with transactions.
Because of that, I don't really consider the L1 block number too useful, but that being said, the information is already there (CUR L1 & L2 block numbers). I don't think it's useful to have it again either.
One alternative could be to display just "PROCESSING", instead of "PROGRESS [ n %]" when polling is enabled?
There was a problem hiding this comment.
I think it would be nice to be able to see how many blocks (and for a future PR; roughly be able to estimate how long the reconstruction will take) are left to be processed and filtered. Given that most, if not all, users would be reconstructing to the latest L1 block, that information seems quite useful. So, even if it doesn't accurately reflect the state of L2, I still think we should include it, just as a general progress bar (it's nice too see say 26%, instead of block 1583).
There was a problem hiding this comment.
Ok. I changed it so that last_l1_block is now always set. When polling goes past it, the percentages should cap at 100%.
src/l1_fetcher.rs
Outdated
| latest_l2_block_nbr: u64, | ||
|
|
||
| first_l1_block: Option<u64>, | ||
| last_l1_block: Option<u64>, |
There was a problem hiding this comment.
Does this need to be an Option anymore?
There was a problem hiding this comment.
Probably not. I'll clean it out 🙂
Prints total progress and number of processed blocks:
