Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash & gather factory deps to snapshot #42

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

tuommaki
Copy link
Collaborator

Factory deps (smart contracts in zkSync) are stored separately in snapshots, but they must be gathered together with storage log entries when fetching the state from L1. This change will do preliminary work required for writing out the separate factory dep snapshot file.

zeapoz and others added 3 commits November 9, 2023 12:33
When exporting snapshot files from L1, each snapshot needs information
where each storage log entry originated from, i.e. the L1 block number
for given storage log entry. It's added to `CommitBlockInfoV1` as an
optional field which is not serialized into JSON.
Factory deps (smart contracts in zkSync) are stored separately in
snapshots, but they must be gathered together with storage log entries
when fetching the state from L1. This change will do preliminary work
required for writing out the separate factory dep snapshot file.
@tuommaki tuommaki requested a review from zeapoz November 10, 2023 11:39
@tuommaki tuommaki self-assigned this Nov 10, 2023
Copy link
Member

@zeapoz zeapoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

Base automatically changed from add-l1-block-nbr-to-commitblockinfo to main November 16, 2023 14:16
Factory deps (smart contracts in zkSync) are stored separately in
snapshots, but they must be gathered together with storage log entries
when fetching the state from L1. This change will do preliminary work
required for writing out the separate factory dep snapshot file.
…c-state-reconstruct into hash-and-gather-factorydeps
@tuommaki tuommaki merged commit 39b5bf1 into main Nov 17, 2023
4 checks passed
@tuommaki tuommaki deleted the hash-and-gather-factorydeps branch November 17, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants