Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: store the last processed block in snapshot #46

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

zeapoz
Copy link
Member

@zeapoz zeapoz commented Dec 7, 2023

Before, we stored the last fetched block and waited until it had processed fully before terminating the main fetching loop. When the fetcher would repeatedly fail to procure a transaction, it would also delay the shutdown process. This change updates the snapshot with the last processed block instead.

Before, we stored the last fetched block and waited until it had processed
fully before terminating the main fetching loop. When the fetcher would
repeatedly fail to procure a transaction, it would also delay the shutdown
process. This change updates the snapshot with the last *processed* block instead.
@zeapoz zeapoz self-assigned this Dec 7, 2023
@zeapoz zeapoz requested a review from tuommaki December 7, 2023 13:13
Copy link
Collaborator

@tuommaki tuommaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zeapoz zeapoz merged commit 006577e into main Dec 7, 2023
4 checks passed
@zeapoz zeapoz deleted the tweak/shutdown-process branch December 7, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants