Skip to content

Commit

Permalink
Downgrade NDK to 27.1.12297006
Browse files Browse the repository at this point in the history
The latest one (27.2.12479018) causes compilation the ring crate for the arm target to fail on the CI (but not locally).
  • Loading branch information
madadam committed Oct 23, 2024
1 parent a479241 commit 3d51ffc
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 15 deletions.
22 changes: 12 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,12 @@ jobs:
# the linux version does currently unconditionally depend on fuse.
run: sudo apt-get install libfuse-dev

- name: Install NDK
uses: nttld/setup-ndk@v1
with:
ndk-version: r27c
link-to-sdk: true
local-cache: true
# - name: Install NDK
# uses: nttld/setup-ndk@v1
# with:
# ndk-version: r27c
# link-to-sdk: true
# local-cache: true

- name: Cache cargo artifacts
uses: actions/cache@v3
Expand All @@ -125,6 +125,8 @@ jobs:
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.toml') }}
restore-keys: |
${{ runner.os }}-cargo-
- name: Cache gradle artifacts
uses: actions/cache@v3
Expand All @@ -142,19 +144,19 @@ jobs:

- name: Run spotless
working-directory: bindings/kotlin
run: ./gradlew spotlessCheck
run: ./gradlew --stacktrace spotlessCheck

- name: Run lint
working-directory: bindings/kotlin
run: ./gradlew lint
run: ./gradlew --stacktrace lint

- name: Run unit tests
working-directory: bindings/kotlin
run: ./gradlew lib:testDebugUnitTest
run: ./gradlew --stacktrace lib:testDebugUnitTest

- name: Build the example app
working-directory: bindings/kotlin
run: ./gradlew example:assembleDebug
run: ./gradlew --stacktrace example:assembleDebug

check_dart_bindings:
name: check dart bindings
Expand Down
3 changes: 1 addition & 2 deletions bindings/dart/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ android {
}

compileSdk = 34
// At time of writing, this is the LTS version
ndkVersion = "27.2.12479018"
ndkVersion "27.1.12297006"

compileOptions {
sourceCompatibility = JavaVersion.VERSION_17
Expand Down
4 changes: 1 addition & 3 deletions bindings/kotlin/lib/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ group = rootProject.group

android {
compileSdkVersion 34

// At time of writing, this is the LTS version
ndkVersion "27.2.12479018"
ndkVersion "27.1.12297006"

namespace 'org.equalitie.ouisync.lib'

Expand Down

0 comments on commit 3d51ffc

Please sign in to comment.