Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert packngo to equinix-sdk-go #81

Merged
merged 2 commits into from
Jun 20, 2024
Merged

chore: convert packngo to equinix-sdk-go #81

merged 2 commits into from
Jun 20, 2024

Conversation

displague
Copy link
Member

@displague displague commented Mar 4, 2024 •
edited
Loading

Converts the driver from the deprecated packngo driver to equinix-sdk-go

Also ioutil is deprecated and was replaced with os

fixes #77

@displague
Copy link
Member Author

This compiles but needs extensive manual testing of all the arguments.

ctreatma
ctreatma approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what exactly to do with this but it looks fine to me. IMO you could merge and then release (possibly using an -alpha suffix on the version tag) and open follow-up PRs for any issues that come up.

@displague displague merged commit 75f8370 into main Jun 20, 2024
2 checks passed
@displague displague deleted the equinix-sdk-go branch June 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctreatma ctreatma ctreatma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to equinix-sdk-go
2 participants
@displague @ctreatma