fix: Correct Fabricv4 API Spec via patching to use valid any type #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For review purposes, it is helpful to keep the manual updates and generated updates in separate commits. We haven't worried about having consistency (patches match the artifacts) at the git-sha level, only at the release level. |
What's an example of why this is a better choice? |
I missed the conversation leading to this choice: |
ctreatma
changed the title
|
This PR is included in version 0.34.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: objectfrom API Spec where intent is to have any type be acceptable from the API handler for that propertygithub.com/stretchr/testifybeing upgraded from version1.8.4to1.9.0