Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated metal-go client for sub-commands ports #290

Closed
wants to merge 1 commit into from
Closed

Updated metal-go client for sub-commands ports #290

wants to merge 1 commit into from

Conversation

codinja1188
Copy link
Contributor

@codinja1188 codinja1188 commented Jun 22, 2023 •
edited
Loading

Breakout from #270

What this PR does / why we need it:

This PR replaces packngo with metal-go for all interactions with the Equinix Metal API specifically for ports sub commands

DISCUSSION POINTS:

Missing Includes and Excludes in Spec for the API "CreatePortVlanAssignmentBatch"

ocobles
ocobles reviewed Jun 23, 2023
View reviewed changes
internal/ports/vlans.go Outdated
return errors.New("no VLAN assignments specified")
}
batch, _, err := c.VLANService.CreateBatch(portID, req, getOpts)
batch, _, err := c.PortService.CreatePortVlanAssignmentBatch(context.Background(), portID).PortVlanAssignmentBatchCreateInput(*req).I
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
batch, _, err := c.PortService.CreatePortVlanAssignmentBatch(context.Background(), portID).PortVlanAssignmentBatchCreateInput(*req).I
batch, _, err := c.PortService.CreatePortVlanAssignmentBatch(context.Background(), portID).PortVlanAssignmentBatchCreateInput(*req).Execute()

Copy link
Contributor Author

@codinja1188 codinja1188 Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be addressed in spec side first missing Includes, Excludes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any issues like this where you are aware that the metal-go client is missing features that are needed for conversion should be noted on the relevant PR and the PR should be placed in draft status. That will protect against accidental merge of changes that are known to be not completely working, and will make it easier for the whole team to understand what issues are blocking the remaining metal-go conversion PRs.

@cprivitere
Copy link
Contributor

Is this good to go or does it need to be set to draft?

@codinja1188 codinja1188 marked this pull request as draft June 30, 2023 16:56
ctreatma
ctreatma reviewed Jul 26, 2023
View reviewed changes
internal/ports/convert.go
Comment on lines +58 to +59
inc := []string{}
exc := []string{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be wired up to the --include and --exclude flags

internal/ports/retrieve.go
Comment on lines +44 to +45
inc := []string{}
exc := []string{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also be wired up to the --include and --exclude flags

@ctreatma
Copy link
Contributor

ctreatma commented Aug 3, 2023

Missing Includes and Excludes in Spec for the API "CreatePortVlanAssignmentBatch"

This should be resolved as of metal-go v0.16.0.

@codinja1188 codinja1188 mentioned this pull request Aug 16, 2023
Closed
15 tasks
@aayushrangwala
Copy link
Contributor

/assign @aayushrangwala

@codinja1188 codinja1188 temporarily deployed to external October 2, 2023 10:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Updated metal-go client for sub-commands ports". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@cprivitere cprivitere temporarily deployed to external October 9, 2023 17:45 — with GitHub Actions Inactive
@codinja1188
Copy link
Contributor Author

Changes are handled in the following PR #355, close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocobles ocobles ocobles left review comments

@ctreatma ctreatma ctreatma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codinja1188 @cprivitere @ctreatma @aayushrangwala @ocobles