-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: BETA loadbalancer service support #362
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, but overall this looks like a great start!
} | ||
|
||
func (m TokenExchanger) Token() (*oauth2.Token, error) { | ||
tokenExchangeURL := "https://iam.metalctrl.io/api-keys/exchange" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know that it would add much here, but if we had a spec for iam.metalcrtl.io we could use a generated client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to consider here: if LBaaS has its own generated client that sits next to the metal client in |
Merged in latest updates and tested create/get/delete commands to verify they work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to consider here: if LBaaS has its own generated client that sits next to the metal client in
equinix-sdk-go
, with its own spec and its own API endpoint, that may indicate that LBaaS CLI commands should go alongside Metal CLI commands in a broader-scoped Equinix CLI (eqx
?eqix
?the-equinix-cli
?) rather than directly in here.
I'm all for dropping metal-cli and making eq-cli or whatever.
Signed-off-by: Marques Johansson <[email protected]>
…quinix-metal emlb branch) Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Part of #411
(Used CPEM's LBaaS Go project as the base. Lots of cleanup ahead. )
This PR introduces the minimal subcommand support to start working with LoadBalancers. This PR does not include ports and pools, which can be added later.
TODO: