Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove submodules init from actions/checkout #118

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Jul 23, 2024

workflow check-upstream-upgrade is consistently failing with error:

fatal: remote error: upload-pack: not our ref 0028d0d7d396775e3c57b122bf1ca8f9e5b020e3
Errors during submodule fetch:
	upstream

I'm not sure what the problem is but seems to be a conflict between the steps in the command upgrade-provider and the version that action/checkout gets. The upgrade-provider command runs git submodule update --force --init so we can continue using action/checkout without submodules

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@ctreatma ctreatma merged commit 5b0c65f into main Jul 24, 2024
17 checks passed
@ctreatma ctreatma deleted the fix-check-upstream-upgrade-action branch July 24, 2024 13:56
Copy link

github-actions bot commented Aug 5, 2024

This PR is included in version 0.14.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants