-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: install pulumictl in makefile #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
ctreatma
reviewed
Aug 20, 2024
ctreatma
reviewed
Aug 20, 2024
@@ -37,13 +51,14 @@ tfgen: only_tfgen generate_examples | |||
generate_examples: examples | |||
|
|||
# Build the tfgen binary and generate the schema | |||
build_schema: $(PULUMICTL_BIN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the dependencies too!
ctreatma
reviewed
Aug 20, 2024
Signed-off-by: Oscar Cobles <[email protected]>
Signed-off-by: Oscar Cobles <[email protected]>
Signed-off-by: Oscar Cobles <[email protected]>
ocobles
force-pushed
the
install-pulumictl-makefile
branch
from
August 20, 2024 15:25
156dafd
to
75d830e
Compare
ctreatma
approved these changes
Aug 20, 2024
This PR is included in version 0.15.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #142