feat: onboarding Aviatrix edge 7.1 device #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rling-equinix
requested changes
May 31, 2024
| name = var.name | ||
| type_code = data.equinix_network_device_type.this.code | ||
| package_code = var.software_package | ||
| version = length(var.vnf_version) > 0 ? var.vnf_version : data.equinix_network_device_software.this.version |
There was a problem hiding this comment.
This is a fixed version module. We don't need to expose the version here.
| account_number = var.account_number | ||
| connectivity = var.connectivity | ||
| term_length = var.term_length | ||
| interface_count = var.interface_count |
There was a problem hiding this comment.
Interface count is also fixed here.
| description = "Billing account number for a device" | ||
| type = string | ||
| validation { | ||
| condition = length(var.account_number) > 0 && var.account_number != null |
There was a problem hiding this comment.
Null check should happen before length check. Alternatively, try function is recommended here.
| } | ||
| } | ||
|
|
||
| variable "software_package" { |
There was a problem hiding this comment.
Let's remove software package here.
| description = "Aviatrix Cloud-Init bootstrap configuration file" | ||
| type = string | ||
| validation { | ||
| condition = length(var.cloud_init_file_id) > 0 |
There was a problem hiding this comment.
Try function is required here to avoid null pointer.
| required_providers { | ||
| equinix = { | ||
| source = "equinix/equinix" | ||
| version = "~> 1.34" |
| required_providers { | ||
| equinix = { | ||
| source = "equinix/equinix" | ||
| version = "~> 1.34" |
| required_providers { | ||
| equinix = { | ||
| source = "equinix/equinix" | ||
| version = "~> 1.34" |
| "launch_version": "UserConnect-6.7.1158"}', owner: 'ubuntu:ubuntu', path: /etc/test/avx_edge_cloud_init.cfg, | ||
| permissions: '0755'} | ||
|
|
||
| Valid user |
There was a problem hiding this comment.
Is it the newest Aviatrix cloud init config file? The format looks weird here.
| | Name | Version | | ||
| | --------------------------------------------------------------------------- | --------- | | ||
| | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3 | | ||
| | <a name="requirement_equinix"></a> [equinix](#requirement\_equinix) | ~> 1.34 | |
There was a problem hiding this comment.
Could you update it to >=1.34?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.