Add links to iframe carousels and adjust size (#1534) #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandolucchesi
suggested changes
Aug 2, 2023
| @@ -10,7 +10,16 @@ import CharCounterEditor from '../components/CharCounterEditor' | |||
| import blocksToText from '../../helpers/blocksToText' | |||
| import type { Rule, Block } from '@sanity/types' | |||
| import type { ColorListValue } from 'sanity-plugin-color-list' | |||
| import { title, frameTitle, description, cookiePolicy, aspectRatio, url, height } from './iframe/sharedIframeFields' | |||
| import { | |||
There was a problem hiding this comment.
changes missing in v3
| width: 100%; | ||
| min-width: 90%; | ||
| /* exactly two items */ | ||
| :first-child:nth-last-child(2), |
There was a problem hiding this comment.
I don't think this is changing anything...
| @@ -25,8 +26,16 @@ const Figure = styled.figure` | |||
| width: 100%; | |||
| ` | |||
| const ItemContainer = styled.div` | |||
| min-width: 45%; | |||
There was a problem hiding this comment.
we should aim to be mobile first, so min-width should be 100%, and then use @media(min-width: ) etcs..
| :first-child:nth-last-child(2) ~ { | ||
| min-width: 50%; | ||
| } | ||
| @media (max-width: 750px) { |
There was a problem hiding this comment.
I think it looks better splitting into 2 columns only for desktop screens
| @@ -25,8 +26,16 @@ const Figure = styled.figure` | |||
| width: 100%; | |||
| ` | |||
| const ItemContainer = styled.div` | |||
| min-width: 45%; | |||
There was a problem hiding this comment.
could also use min-width: calc(50% - var(--space-medium)) (50% minus the gap of the grid)
| } | ||
| @media (max-width: 750px) { | ||
| min-width: 100%; | ||
| } |
There was a problem hiding this comment.
const ItemContainer = styled.div`
width: 100%;
min-width: 100%;
@media (min-width: 1024px) {
min-width: calc(50% - var(--space-medium));
}
`
fernandolucchesi
approved these changes
Aug 15, 2023
fernandolucchesi
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.