Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padms/1816 #1841

Merged
merged 37 commits into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
a44c9b7
♿️ Add to calendar aria-lable #1816
padms Aug 17, 2023
94d5ff0
♻️ No string concatenation #1816
padms Aug 17, 2023
501024b
💬 improve aria lable #1816
padms Aug 17, 2023
14fece3
💬 No quotes #1816
padms Aug 17, 2023
446a327
💬 Remove unnecessary { #1816
padms Aug 17, 2023
a7fe17c
Merge branch 'main' into padms/1816
padms Sep 21, 2023
d0b85ab
💬 Remove quotes #1816
padms Sep 21, 2023
567593f
⚗️ Experiment script to store prod tags #1770
fernandolucchesi Sep 21, 2023
a17f673
⚗️ Move script to first job #1770
fernandolucchesi Sep 21, 2023
19d0d6c
⚗️ Adjust path #1770
fernandolucchesi Sep 21, 2023
fbffc30
⚗️ Experiment different file path #1770
fernandolucchesi Sep 21, 2023
5f2a64f
🐛 Fix commit script #1770
fernandolucchesi Sep 21, 2023
de7c5ae
⚗️ Test script #1770
fernandolucchesi Sep 21, 2023
97ad455
⚗️ Perform experiments #1770
fernandolucchesi Sep 21, 2023
895eb8b
⚗️ Experiment getting tags from json #1770
fernandolucchesi Sep 21, 2023
b288d3b
🔊 Add logs #1770
fernandolucchesi Sep 21, 2023
26b5c13
⚗️ Experiment array manipulation #1770
fernandolucchesi Sep 21, 2023
47b5eea
✨ Experiment new output #1770
fernandolucchesi Sep 21, 2023
db2c89c
⚗️ Try a different approach #1770
fernandolucchesi Sep 21, 2023
9805786
🐛 Fix string concatenation issue #1770
fernandolucchesi Sep 21, 2023
5ae3327
🐛 Fix array concatenation #1770
fernandolucchesi Sep 21, 2023
5b371a5
🐛 Fix array concatenation #1770
fernandolucchesi Sep 21, 2023
a3e5ca9
⚗️ Experiment with 'add' #1770
fernandolucchesi Sep 21, 2023
0e87a63
⚗️ Experiment with add #1770
fernandolucchesi Sep 21, 2023
ec1c890
⚗️ Experiment #1770
fernandolucchesi Sep 21, 2023
7925678
⚗️ Experiment different way #1770
fernandolucchesi Sep 21, 2023
8d8ff29
⚗️ New way of concatenating array #1770
fernandolucchesi Sep 21, 2023
9aa80c6
✨ Store prod image tags during prod deploy #1770
fernandolucchesi Sep 21, 2023
e43405a
🗑️ Disable old ghcr cleanup script #1770
fernandolucchesi Sep 21, 2023
b0be4e0
🐛 Fix skip-tags value #1770
fernandolucchesi Sep 21, 2023
758ec5a
🐛 Experiment with v2 #1770
fernandolucchesi Sep 21, 2023
8686349
🐛 Add cutoff param #1770
fernandolucchesi Sep 21, 2023
c9c34cf
🐛 Add timezone #1770
fernandolucchesi Sep 21, 2023
6e6bfbc
⚗️ Experiment dry run #1770
fernandolucchesi Sep 21, 2023
99cb9e7
⚗️ Experiment retention #1770
fernandolucchesi Sep 21, 2023
9c370c8
Merge branch 'main' into padms/1816
padms Sep 25, 2023
9623f35
Merge branch 'main' into padms/1816
padms Sep 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sanityv3/schemas/textSnippets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ const snippets: textSnippet = {
defaultValue: 'Details',
group: groups.eventPromotion,
},
add_to_calendar_aria_label: {
title: 'Add event to calendar',
defaultValue: `Add {eventTitle} to calendar`,
group: groups.eventPromotion,
},
search: {
title: 'Search',
defaultValue: 'Search',
Expand Down
13 changes: 12 additions & 1 deletion web/pageComponents/topicPages/AddToCalendar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,19 @@ const AddToCalendar = ({ eventDate, title, location }: AddToCalendarProps) => {

if (!fileData) return null
const atc = intl.formatMessage({ id: 'add_to_calendar_event', defaultMessage: 'Add to Calendar' })
const atcAriaLabel = intl.formatMessage(
{
id: 'add_to_calendar_aria_label',
defaultMessage: `Add {eventTitle} to calendar`,
},
{ eventTitle: title },
)
return (
<Button {...(fileData && { href: fileData as string, download: `${title.replace(/ /g, '_')}.ics` })}>
<Button
aria-label={atcAriaLabel}
id="atc"
{...(fileData && { href: fileData as string, download: `${title.replace(/ /g, '_')}.ics` })}
>
{/* <Icon data={add} /> */}
{atc}
</Button>
Expand Down