Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbail url for archived items in news #2639

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Fix thumbail url for archived items in news #2639

merged 6 commits into from
Nov 5, 2024

Conversation

padms
Copy link
Contributor

@padms padms commented Nov 5, 2024

No description provided.

@padms padms requested a review from a team as a code owner November 5, 2024 10:36
@padms padms self-assigned this Nov 5, 2024
@@ -33,6 +33,6 @@ export const mapData: MapDataType = (article) => {
],
countryTags: [country.trim()].filter(identity),
year,
thumbnailUrl: thumbnailURL ? `https://envisstoragedev.blob.core.windows.net/equinor-archive-content${thumbnailURL}` : null,
thumbnailUrl: thumbnailURL ? thumbnailURL : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternative:
thumbnailUrl: thumbnailURL || null,

Copy link
Contributor

@millianapia millianapia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@padms padms merged commit cdb9c7d into main Nov 5, 2024
4 checks passed
@padms padms deleted the padms/2631 branch December 9, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants