Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: embed vars🐇 #908

Merged
merged 8 commits into from
Feb 10, 2025
Merged

build: embed vars🐇 #908

merged 8 commits into from
Feb 10, 2025

Conversation

Gustav-Eikaas
Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas commented Feb 7, 2025

Speeds up pageload by around 200ms - 1s depending on external service's ability to respond quickly
Removes dependency on azure app configuration, utilizing radix environment variables directly

@github-actions github-actions bot added docker Pull requests that update Docker code missing test There doesnt seem to be a test associated with this labels Feb 7, 2025
@github-actions github-actions bot added core Changes core services header Changes to the header module invitation for punchout Changes to the IPO module plantConfig Changes to the plantconfig module preservation Changes to preservation module labels Feb 7, 2025
@Gustav-Eikaas Gustav-Eikaas changed the title embed vars build: embed vars🐇 Feb 7, 2025
@Gustav-Eikaas Gustav-Eikaas self-assigned this Feb 7, 2025
@Gustav-Eikaas Gustav-Eikaas marked this pull request as ready for review February 7, 2025 11:11
@Gustav-Eikaas Gustav-Eikaas merged commit 81ed877 into master Feb 10, 2025
5 checks passed
@Gustav-Eikaas Gustav-Eikaas deleted the feat/embed-vars-directly branch February 10, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes core services docker Pull requests that update Docker code header Changes to the header module invitation for punchout Changes to the IPO module missing test There doesnt seem to be a test associated with this plantConfig Changes to the plantconfig module preservation Changes to preservation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants