Skip to content

Commit

Permalink
Run c++ tests only as separate entity
Browse files Browse the repository at this point in the history
6e84e4d changed the way tests were written, but doing so dropped
separation between c.segy and c++ tests.

By bringing it back we remove duplicated test runs (reducing cases run
in test entities 1-4 from 101 to 81, by 20 tests that belong to the c++
group and are not affected by mmap/lsb distinction).

Note that c++ code is built and tests are run regardless of the
"experimental" build option. That option impacts installation only.
  • Loading branch information
achaikou committed Feb 5, 2025
1 parent d544408 commit bf3cfa6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ target_compile_definitions(c.segy
PRIVATE
${mmap}
)
add_test(NAME c.segy COMMAND c.segy)
add_test(NAME c.segy.mmap COMMAND c.segy --test-mmap)
add_test(NAME c.segy.lsb COMMAND c.segy --test-lsb)
add_test(NAME c.segy.mmap.lsb COMMAND c.segy --test-mmap --test-lsb)
add_test(NAME c.segy COMMAND c.segy [c.segy])
add_test(NAME c.segy.mmap COMMAND c.segy [c.segy] --test-mmap)
add_test(NAME c.segy.lsb COMMAND c.segy [c.segy] --test-lsb)
add_test(NAME c.segy.mmap.lsb COMMAND c.segy [c.segy] --test-mmap --test-lsb)
add_test(NAME cpp.segy COMMAND c.segy [c++])

0 comments on commit bf3cfa6

Please sign in to comment.