Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fields from AHM_ANALYSIS #606

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Remove fields from AHM_ANALYSIS #606

merged 1 commit into from
Apr 4, 2024

Conversation

oyvindeide
Copy link
Contributor

@oyvindeide oyvindeide commented Mar 21, 2024 •
edited
Loading

Related to: #318

sondreso
sondreso approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/commit body needs an update to explain why this feature is removed.
We should also create an issue (pointing to this commit) to optimize the code to not load all field parameters into memory

@oyvindeide
Remove fields from AHM_ANALYSIS
39bf1c0 
Fields were only half implemented in the AHM_ANALYSIS workflow,
and it was not possible to use the workflow with FIELDS in any
real cases as it would run out of memory. We remove the option
here, meaning that the workflow will only work for scalar parameters.
@oyvindeide oyvindeide enabled auto-merge (rebase) April 4, 2024 10:53
@oyvindeide oyvindeide mentioned this pull request Apr 4, 2024
Open
@oyvindeide oyvindeide merged commit 9f86581 into equinor:main Apr 4, 2024
9 checks passed
@oyvindeide oyvindeide deleted the remove_field branch April 4, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oyvindeide @sondreso