Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Python-only components to Python directory and adjust code and setup for generating Dash components #1674

Merged
merged 24 commits into from
Oct 5, 2023

Conversation

rubenthoms
Copy link
Collaborator

  • Created wrapper components for typescript/packages
  • Removed stories and tests in Python directory
  • Adjusted package.json entry points in group-tree package
  • Added DashSubsurfaceViewer to subsurface-viewer package

…ed code and setup

- Created wrapper components for `typescript/packages`
- Removed stories and tests in Python directory
- Adjusted package.json entry points in `group-tree` package
- Added `DashSubsurfaceViewer` to `subsurface-viewer` package
@rubenthoms rubenthoms changed the title refactor: Moved Python-only components to Python directory and adjusted code and setup for generating Dash components Moved Python-only components to Python directory and adjusted code and setup for generating Dash components Sep 28, 2023
@rubenthoms rubenthoms changed the title Moved Python-only components to Python directory and adjusted code and setup for generating Dash components refactor: Moved Python-only components to Python directory and adjusted code and setup for generating Dash components Sep 28, 2023
@rubenthoms rubenthoms changed the title refactor: Moved Python-only components to Python directory and adjusted code and setup for generating Dash components refactor: Move Python-only components to Python directory and adjust code and setup for generating Dash components Sep 28, 2023
@rubenthoms rubenthoms marked this pull request as ready for review September 29, 2023 08:51
@rubenthoms rubenthoms self-assigned this Sep 29, 2023
@rubenthoms rubenthoms added epic CeeSol Task owned by Ceetron Solutions labels Sep 29, 2023
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM.

Comment on lines 25 to 29
matrix:
include:
- python-version: "3.8"
- python-version: "3.9"
- python-version: "3.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to

Suggested change
matrix:
include:
- python-version: "3.8"
- python-version: "3.9"
- python-version: "3.10"
matrix:
python-version: ["3.8", "3.9", "3.19"]

@rubenthoms rubenthoms merged commit b5233c7 into equinor:master Oct 5, 2023
5 checks passed
@hkfb
Copy link
Collaborator

hkfb commented Oct 5, 2023

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb hkfb added the released label Oct 5, 2023
@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 0.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb
Copy link
Collaborator

hkfb commented Dec 12, 2023

🎉 This issue has been resolved in version [email protected] 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CeeSol Task owned by Ceetron Solutions epic released
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

5 participants