feat: Enhanced "refine" keyword for wells. #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscb
added
enhancement
hkfb
reviewed
Oct 12, 2023
w1nklr
reviewed
Oct 12, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/utils/spline.ts
Outdated
Show resolved
Hide resolved
w1nklr
approved these changes
Oct 13, 2023
hkfb
reviewed
Oct 13, 2023
hkfb
requested changes
Oct 13, 2023
typescript/packages/subsurface-viewer/src/layers/wells/utils/generateSyntheticWell.ts
Outdated
Show resolved
Hide resolved
-May be either a boolean or a number specifying number of new points inserted between pairs of existing points.
nilscb
force-pushed
the
WellsParameterizedRefine
branch
from
7e56c7b to
3aecd43
Compare
hkfb
requested changes
Oct 13, 2023
typescript/packages/subsurface-viewer/src/layers/wells/utils/spline.test.ts
Outdated
Show resolved
Hide resolved
hkfb
requested changes
Oct 13, 2023
w1nklr
requested changes
Oct 13, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
w1nklr
approved these changes
Oct 19, 2023
-May be either a boolean or a number specifying number of new points inserted between pairs of existing points.
…ellsParameterizedRefine
w1nklr
approved these changes
Oct 20, 2023
- removed use of lodash range function. In certaing cases it incuded the end value and returned to many valures.
w1nklr
approved these changes
Oct 20, 2023
w1nklr
approved these changes
Oct 23, 2023
hkfb
requested changes
Oct 24, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.stories.tsx
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.stories.tsx
Show resolved
Hide resolved
hkfb
approved these changes
Oct 24, 2023
Comment on lines
+528
to
+540
| <Root> | ||
| <div className={classes.main}> | ||
| <SubsurfaceViewer {...props} /> | ||
| </div> | ||
| <Slider | ||
| min={1} | ||
| max={10} | ||
| defaultValue={1} | ||
| step={1} | ||
| onChange={handleChange} | ||
| valueLabelDisplay={"auto"} | ||
| /> | ||
| </Root> |
There was a problem hiding this comment.
There's a lot of wasted vertical space between the story and the controls, but I guess it does the job
hkfb
pushed a commit
that referenced
this pull request
Oct 24, 2023
# [0.5.0](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.5.0) (2023-10-24) ### Features * Enhanced "refine" keyword for wells. ([#1693](#1693)) ([0b9c72e](0b9c72e))
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-May be either a boolean or a number specifying number of new points inserted between pairs of existing points.