Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Grid3d Layer API and cursor readout enhancements. #1714

Merged
merged 24 commits into from
Oct 19, 2023
Merged

feat: Grid3d Layer API and cursor readout enhancements. #1714

merged 24 commits into from
Oct 19, 2023

Conversation

LeonidPolukhin
Copy link
Collaborator

  1. Memory usage reduced.
  2. Accepts data as JavaScript typed arrays.
  3. Cursor reradout works correctly displaying relevant x, y, depth and property values.

leonid.polukhin added 20 commits October 11, 2023 12:59
version updated
7fafc82
unproject3d enabled
38cbd80
Grid3D: typed arrays as inputs
80f006f
Grid3d: story book cleanup
4791709
Grid3D: test data and new story added
51ec9db
Grid3d: webwoker fixed
16dffdb
Grid3d: index buffer for triangles
6fa6ef1
refactor(grid3d): shader code cleaning up
dea41d4
docs(grid3d): a[pi docs updated
279b362
feat(grid3d): no index array for triangles mesh
8d67a07
refactor: use gl_VertexID instead of array
42194cd
refactor(grid3d): shaders cleanup
7c92b2b
update(grid3d): pickable flag added
9bfe9d5
chore(grid3d): save changes
f2ea43b
fix(grid3d): zDownwards fixed
c5fc5c1
fix(grid3d): min picking shaders with coloring
a275afa
fix(grid3d): layer props updated in storybook
4c49d79
fix(grid3d): property readout fixed
a21b180
fix(grid3d): dont show nan property value
0217cbb
test(grid3d): storybook cleanup
3438fdd
@LeonidPolukhin LeonidPolukhin added bug Something isn't working enhancement New feature or request AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Oct 18, 2023
@LeonidPolukhin LeonidPolukhin self-assigned this Oct 18, 2023
@LeonidPolukhin LeonidPolukhin changed the title feat (grid3d): Grid3d Layer API and cursor readout enhancements. feat: Grid3d Layer API and cursor readout enhancements. Oct 18, 2023
@nilscb nilscb self-requested a review October 18, 2023 09:31
@LeonidPolukhin LeonidPolukhin merged commit 147292d into equinor:master Oct 19, 2023
hkfb pushed a commit that referenced this pull request Oct 19, 2023
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
de016da 
# [0.4.0](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.4.0) (2023-10-19)

### Features

* Grid3d Layer API and cursor readout enhancements. ([#1714](#1714)) ([147292d](147292d))
@hkfb
Copy link
Collaborator

hkfb commented Oct 19, 2023

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb hkfb added the released label Oct 19, 2023
This was linked to issues Oct 19, 2023
[NGRM] - Reduce memory usage in Grid3D Layer. #1712
Closed
[NGRM] - Fix 3D and property value readouts in Grid3D Layer. #1713
Closed
@LeonidPolukhin LeonidPolukhin deleted the ReduceMemUsageGrid3D branch March 6, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilscb nilscb nilscb approved these changes

@hkfb hkfb Awaiting requested review from hkfb

@w1nklr w1nklr Awaiting requested review from w1nklr

Assignees

@LeonidPolukhin LeonidPolukhin

Labels
AspenTech Task owned by AspenTech bug Something isn't working enhancement New feature or request map-component Issues related to the map component. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NGRM] - Fix 3D and property value readouts in Grid3D Layer. [NGRM] - Reduce memory usage in Grid3D Layer.
3 participants
@LeonidPolukhin @hkfb @nilscb