fix: Apply local phong lighting to MapLayer and Grid3DLayer as already done in TriangleLayer. #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nilscb
commented
Oct 27, 2023
nilscb
commented
- This algorithm is a modification of Luma's version in that it accounts for two sided lighting.
- also rename privatLayer.ts to privatGrid3dLayer.ts to align with naming convention
…ne in TriangleLayer. - This algorithm is a modification of Luma's version in that it accounts for two sided lighting. - also rename privatLayer.ts to privatGrid3dLayer.ts to align with naming convention
w1nklr
approved these changes
Oct 27, 2023
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.