Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Track caption and readout font size and text truncation #1941

Merged
merged 9 commits into from
Mar 5, 2024
Merged

feat: Track caption and readout font size and text truncation #1941

merged 9 commits into from
Mar 5, 2024

Conversation

Vladimir-Kokin
Copy link
Collaborator

  • Refactor readout code, set HTML elements CSS props with CSS style when possible to allow it customization: font size, readout and readout elements widthes and so on
  • Long track captions, readout names, values and units truncated with ellipsys
  • Add tooltips to show not truncated text

See #1715, #1874, #1888

@Vladimir-Kokin Vladimir-Kokin self-assigned this Feb 29, 2024
@Vladimir-Kokin Vladimir-Kokin added the AspenTech Task owned by AspenTech label Feb 29, 2024
@hkfb
Copy link
Collaborator

hkfb commented Feb 29, 2024

@Vladimir-Kokin you probably need to update the test snapshots. See https://github.com/equinor/webviz-subsurface-components/tree/master/typescript#smoke-tests. Let me know if you need help with running the docker scripts.

@Vladimir-Kokin
Copy link
Collaborator Author

@hkfb I have no docker installed on my computer
My Windows do not want to be upgraded. It always undoes an upgrade to new version

@Vladimir-Kokin Vladimir-Kokin merged commit ff14b41 into master Mar 5, 2024
12 checks passed
@Vladimir-Kokin Vladimir-Kokin deleted the TrackTitleFontSizeAndTextTruncation branch March 5, 2024 11:55
hkfb pushed a commit that referenced this pull request Mar 5, 2024
@semantic-release-bot
chore(release): [email protected] [skip ci]
44d5298 
# [1.5.0](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.5.0) (2024-03-05)

### Features

* Track caption and readout font size and text truncation ([#1941](#1941)) ([ff14b41](ff14b41)), closes [#1715](#1715) [#1874](#1874) [#1888](#1888)
@hkfb
Copy link
Collaborator

hkfb commented Mar 5, 2024

🎉 This issue has been resolved in version [email protected] 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkfb hkfb hkfb approved these changes

@mirisb mirisb Awaiting requested review from mirisb

Assignees

@Vladimir-Kokin Vladimir-Kokin

Labels
AspenTech Task owned by AspenTech enhancement New feature or request released well-log-viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vladimir-Kokin @hkfb