Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored data channels #504

Merged
merged 80 commits into from
Jan 23, 2024
Merged

Refactored data channels #504

merged 80 commits into from
Jan 23, 2024

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Dec 8, 2023 •
edited
Loading

This PR contains the following changes:

  • Refactoring of data channels (naming and concept)
  • Performance improvements (related to data channel experience)
  • Refactoring of consumers of data channels (publishers and receivers)

Closes #421.
Closes #184 although there might be some further improvements.

Some performance improvements were taken out of this PR due to unknown possible consequences and are going to be implemented in another PR.

rubenthoms and others added 30 commits October 26, 2023 14:33
@rubenthoms
Started implementation
2efa9ab
@rubenthoms
Further implementation, switched to ReactQuery v5
fe563a4
@rubenthoms
Further implementation
46088c7
@HansKallekleiv
Improved performance of sumo access
f797c2c
@rubenthoms
Implemented new start screen logic, new components, adjustments
389bdf1
@rubenthoms
Further implemented RealizationPicker
88289fc
@rubenthoms
Further implementation
495a341
@rubenthoms
Added queries for response fetching
95c60a3
@rubenthoms
Merge remote-tracking branch 'origin/main' into new-inplace-volumetrics
6c5ef89
@rubenthoms
Auto stash before merge of "new-inplace-volumetrics" and "origin/main"
8d2ef78
@rubenthoms
Further implementation
2f62227
@rubenthoms
Merge remote-tracking branch 'origin/main' into new-inplace-volumetrics
b2a85d6
@rubenthoms
Further adjustments
68e9ae9
@rubenthoms
Further implementation
02e9018
@rubenthoms
Started changing channel patterns/naming
b02fbff
@rubenthoms
Started implementing new channel architecture
c50a21f
@rubenthoms
Next iteration
c22cb47
@rubenthoms
Adjusted GUI and added multi program support
e9d239f
@rubenthoms
Multi-program support, and other adjustments
875b06c
@rubenthoms
Multiple adjustments and new implementations
1a03b8f
@rubenthoms
Improved matrix plotting
5b49361
@rubenthoms
Removed old broadcast architecture, introduced and improved new one
df5db8c
@rubenthoms
Started adjusting visualization layer
fdbb336
@rubenthoms
Added unit to time series matrix module channel
0864c5b
@rubenthoms
Adjustments to data channel visualization and overall UX improvements
353f157
@rubenthoms
Improvements to visualization layer and expanded ts logic
3e8434f
@rubenthoms
Adjusted channel framework
2634a87
@rubenthoms
Merge remote-tracking branch 'equinor/main' into refactored-data-chan…
241e122 
…nels
@rubenthoms
Further adjustments
5390d17
@rubenthoms
Naming adjustments and started using unit conversion
45f61d2
@rubenthoms
Copy link
Collaborator Author

rubenthoms commented Jan 5, 2024 •
edited
Loading

Review suggestions:

@rubenthoms rubenthoms mentioned this pull request Jan 12, 2024
Merged
jorgenherje
jorgenherje requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive! Great work! 👍

Tested and review, with main focus on SimulationTimeSeriesMatrix

Some minor, non-crucial, comments regarding naming and function usage. And two comments with minor adjustments regarding functionality (first and last comment below)

jorgenherje
jorgenherje approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

sigurdp
sigurdp approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@sigurdp sigurdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rubenthoms rubenthoms merged commit 5cecfeb into equinor:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdp sigurdp sigurdp approved these changes

@HansKallekleiv HansKallekleiv HansKallekleiv approved these changes

@jorgenherje jorgenherje jorgenherje approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees

@rubenthoms rubenthoms

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
4 participants
@rubenthoms @sigurdp @HansKallekleiv @jorgenherje