-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
800 fix minor realization filter issues #801
Merged
jorgenherje
merged 8 commits into
equinor:main
from
jorgenherje:800-fix-minor-realization-filter-issues
Nov 8, 2024
Merged
800 fix minor realization filter issues #801
jorgenherje
merged 8 commits into
equinor:main
from
jorgenherje:800-fix-minor-realization-filter-issues
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opacity on header and content, not buttons
- Move dialog to settings panel level - Add GUI events and state in message broker for top level handling
…ation-filter-issues
Make usage of settings panel width GUI state instead
jorgenherje
force-pushed
the
800-fix-minor-realization-filter-issues
branch
from
November 7, 2024 07:44
ac79454
to
1c4b3dd
Compare
jorgenherje
force-pushed
the
800-fix-minor-realization-filter-issues
branch
from
November 7, 2024 07:59
1c4b3dd
to
4684aa0
Compare
Anders2303
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally it seems fine to merge.
I found some small code quality things that migth want to be changed before merging, but purely optional
...nd/src/framework/internal/components/EnsembleRealizationFilter/ensembleRealizationFilter.tsx
Outdated
Show resolved
Hide resolved
...ightSettingsPanel/private-components/RealizationFilterSettings/realizationFilterSettings.tsx
Outdated
Show resolved
Hide resolved
...ightSettingsPanel/private-components/RealizationFilterSettings/realizationFilterSettings.tsx
Outdated
Show resolved
Hide resolved
...ightSettingsPanel/private-components/RealizationFilterSettings/realizationFilterSettings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/framework/internal/components/RightSettingsPanel/rightSettingsPanel.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #800