Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

800 fix minor realization filter issues #801

Merged

Conversation

jorgenherje
Copy link
Collaborator

Closes: #800

Opacity on header and content, not buttons
- Move dialog to settings panel level
- Add GUI events and state in message broker for top level handling
@jorgenherje jorgenherje added the enhancement New feature or request label Nov 6, 2024
@jorgenherje jorgenherje self-assigned this Nov 6, 2024
@jorgenherje jorgenherje force-pushed the 800-fix-minor-realization-filter-issues branch from ac79454 to 1c4b3dd Compare November 7, 2024 07:44
@jorgenherje jorgenherje force-pushed the 800-fix-minor-realization-filter-issues branch from 1c4b3dd to 4684aa0 Compare November 7, 2024 07:59
Copy link
Collaborator

@Anders2303 Anders2303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally it seems fine to merge.

I found some small code quality things that migth want to be changed before merging, but purely optional

@jorgenherje jorgenherje merged commit 09109b0 into equinor:main Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix minor issues for RealizationFilter
2 participants