-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments to backend (and related required changes to frontend) in preparation of 2D viewer #808
Merged
rubenthoms
merged 7 commits into
equinor:main
from
rubenthoms:backend-changes-for-2d-viewer
Dec 3, 2024
Merged
Adjustments to backend (and related required changes to frontend) in preparation of 2D viewer #808
rubenthoms
merged 7 commits into
equinor:main
from
rubenthoms:backend-changes-for-2d-viewer
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenthoms
changed the title
Adjustments to backend in preparation of 2D viewer
Adjustments to backend (and related required changes to frontend) in preparation of 2D viewer
Nov 18, 2024
rubenthoms
requested review from
Anders2303
and removed request for
Anders2303
November 18, 2024 15:16
rubenthoms
force-pushed
the
backend-changes-for-2d-viewer
branch
from
November 18, 2024 15:53
c51d31e
to
01d67ed
Compare
Co-authored-by: Hans Kallekleiv <[email protected]>
rubenthoms
force-pushed
the
backend-changes-for-2d-viewer
branch
from
November 18, 2024 15:55
01d67ed
to
f88328b
Compare
This was referenced Nov 18, 2024
Merged
Anders2303
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me, nice work! I found some smaller issues that should be resolved before I think we're good to merge
backend_py/primary/primary/services/smda_access/drogon/drogon_smda_access.py
Outdated
Show resolved
Hide resolved
backend_py/primary/primary/services/ssdl_access/_ssdl_get_request.py
Outdated
Show resolved
Hide resolved
Anders2303
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.