Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to backend (and related required changes to frontend) in preparation of 2D viewer #808

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

rubenthoms
Copy link
Collaborator

No description provided.

@rubenthoms rubenthoms changed the title Adjustments to backend in preparation of 2D viewer Adjustments to backend (and related required changes to frontend) in preparation of 2D viewer Nov 18, 2024
@rubenthoms rubenthoms marked this pull request as ready for review November 18, 2024 15:16
@rubenthoms rubenthoms requested review from Anders2303 and removed request for Anders2303 November 18, 2024 15:16
@rubenthoms rubenthoms force-pushed the backend-changes-for-2d-viewer branch from c51d31e to 01d67ed Compare November 18, 2024 15:53
Co-authored-by: Hans Kallekleiv <[email protected]>
Copy link
Collaborator

@Anders2303 Anders2303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me, nice work! I found some smaller issues that should be resolved before I think we're good to merge

Copy link
Collaborator

@Anders2303 Anders2303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rubenthoms rubenthoms merged commit 20542c9 into equinor:main Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants