feat: add new GC rules for release with version #6469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6469 +/- ##
==========================================
+ Coverage 15.12% 15.13% +0.01%
==========================================
Files 3675 3675
Lines 377005 377085 +80
==========================================
+ Hits 57018 57072 +54
- Misses 314540 314551 +11
- Partials 5447 5462 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
iutx
reviewed
Dec 16, 2024
| // ListReleaseByAppAndProject list release by application_id and project_id, version is not empty | ||
| func (client *ReleaseConfigDB) ListReleaseByAppAndProject(projectID int64, appID int64) ([]Release, error) { | ||
| var releases []Release | ||
| if err := client.Select([]string{"release_id", "cluster_name", "version"}).Where("application_id = ? AND project_id =? AND version != ''", appID, projectID).Order("updated_at ASC").Find(&releases).Error; err != nil { |
There was a problem hiding this comment.
Remove unnecessary code Select([]string{"release_id", "cluster_name", "version"}).
There was a problem hiding this comment.
Format code in fragment link, e.g. Where, Order.
| // ListExpireReleaseWithVersion list release that has not been referenced before a given point in time and version is not empty | ||
| func (client *ReleaseConfigDB) ListExpireReleaseWithVersion(projectID int64, applicationID int64, before time.Time) ([]Release, error) { | ||
| var releases []Release | ||
| if err := client.Select([]string{"release_id", "cluster_name", "version"}).Where("reference <= ?", 0).Where("updated_at < ?", before).Where("version != ''"). |
There was a problem hiding this comment.
Remove unnecessary code fragment Select.
| @@ -1055,6 +1055,59 @@ func (s *ReleaseService) GetLatestReleasesByProjectAndVersion(projectID int64, v | |||
| return &latests, nil | |||
| } | |||
|
|
|||
| func (s *ReleaseService) FindExpiredReleaseBefore(now time.Time) ([]db.Release, error) { | |||
| // 7 days before | |||
| d, err := time.ParseDuration(strutil.Concat("-", "168", "h")) | |||
There was a problem hiding this comment.
Hard code is not recommend, move to the config file pls.
| releaseCount := len(releases) | ||
| expiredCount := len(expiredReleases) | ||
|
|
||
| if releaseCount <= 10 { |
| if releaseCount <= 10 { | ||
| // If the quantity of release is less than 10, there is no need to delete | ||
| continue | ||
| } else if releaseCount < 30 { |
|
|
||
| for i := range deleteRelease { | ||
| release := deleteRelease[i] |
| @@ -572,3 +574,86 @@ version: "2.0" | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestReleaseServiceGC(t *testing.T) { | |||
haiqingchq
force-pushed
the
feature/gc-rules
branch
from
da14758 to
84ef097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added a GC rule for releases with version on top of the original GC rule
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @iutx @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.