-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: waitgroup in gorouting not done in time when list runtimes has error #6473
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6473 +/- ##
==========================================
- Coverage 15.14% 15.11% -0.03%
==========================================
Files 3674 3675 +1
Lines 376844 377006 +162
==========================================
- Hits 57076 56990 -86
- Misses 314307 314568 +261
+ Partials 5461 5448 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
… with diceyml.New
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sfwn
What this PR does / why we need it:
fix waitgroup in gorouting not done in time when
list runtimes
has errorWhich issue(s) this PR fixes:
Specified Reviewers:
/assign @iutx
ChangeLog
list runtimes
has errorNeed cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.