Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waitgroup in gorouting not done in time when list runtimes has error #6473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Dec 4, 2024

What this PR does / why we need it:

fix waitgroup in gorouting not done in time when list runtimes has error

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English fix waitgroup in gorouting not done in time when list runtimes has error
🇨🇳 中文 修复gorouting中的waitgroup没有在错误的时候done导致runtime界面卡主

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx December 4, 2024 01:42
@CeerDecy CeerDecy changed the title Fix/runtime list fix: waitgroup in gorouting not done in time when list runtimes has error Dec 4, 2024
@erda-bot erda-bot added the bugfix label Dec 4, 2024
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/tools/orchestrator/services/runtime/runtime.go Outdated Show resolved Hide resolved
internal/tools/orchestrator/services/runtime/runtime.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 15.11%. Comparing base (9aaa584) to head (73a961a).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...nal/tools/orchestrator/services/runtime/runtime.go 0.00% 37 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6473      +/-   ##
==========================================
- Coverage   15.14%   15.11%   -0.03%     
==========================================
  Files        3674     3675       +1     
  Lines      376844   377006     +162     
==========================================
- Hits        57076    56990      -86     
- Misses     314307   314568     +261     
+ Partials     5461     5448      -13     
Flag Coverage Δ
by-github-actions 15.11% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nal/tools/orchestrator/services/runtime/runtime.go 13.05% <0.00%> (-0.07%) ⬇️

... and 23 files with indirect coverage changes

@CeerDecy CeerDecy requested a review from iutx December 4, 2024 05:47
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants