Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1093

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Cleanup #1093

merged 2 commits into from
Feb 18, 2020

Conversation

JohanMabille
Copy link
Member

@JohanMabille JohanMabille commented Feb 13, 2020

Fixes #1092

@JohanMabille JohanMabille changed the title WIP - Removed backup folder WIP - Cleanup Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #1093 into master will increase coverage by <.01%.
The diff coverage is 68.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
+ Coverage    50.2%    50.2%   +<.01%     
==========================================
  Files         528      528              
  Lines      101588   101586       -2     
==========================================
- Hits        51003    51002       -1     
+ Misses      50585    50584       -1
Impacted Files Coverage Δ
proteus/mprans/RANS3PSed.py 0% <0%> (ø) ⬆️
proteus/mprans/Kappa.py 11.45% <1.63%> (-0.28%) ⬇️
proteus/mprans/MoveMesh.py 10.49% <10%> (-0.4%) ⬇️
proteus/mprans/PresInit.py 28.93% <10%> (-0.41%) ⬇️
proteus/mprans/PresInc.py 70.56% <100%> (-0.13%) ⬇️
proteus/mprans/SW2DCV.py 87.05% <100%> (+0.05%) ⬆️
proteus/mprans/GN_SW2DCV.py 85.31% <100%> (+0.09%) ⬆️
proteus/elastoplastic/ElastoPlastic.py 76.09% <100%> (+0.11%) ⬆️
proteus/mprans/SW2D.py 8.51% <2.22%> (-0.37%) ⬇️
proteus/mprans/MCorr.py 56.88% <62.5%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9c7f9...30f239f. Read the comment docs.

@JohanMabille JohanMabille force-pushed the cleanup branch 2 times, most recently from 7f138a1 to f9238ea Compare February 13, 2020 14:31
@tridelat
Copy link
Member

Thanks for replacing the import * and good practice things like numpy->np. Was the mprans2 folder introduced by mistake by #1068 ? Didn't catch that

@JohanMabille
Copy link
Member Author

JohanMabille commented Feb 13, 2020

mprans2 was a backup folder while we were migrating mprans to xtensor. It should have been removed from #1068 but unfortunately I forgot to do so.

@JohanMabille JohanMabille force-pushed the cleanup branch 5 times, most recently from d75f9b7 to 30f239f Compare February 17, 2020 20:23
@JohanMabille JohanMabille changed the title WIP - Cleanup Cleanup Feb 17, 2020
@JohanMabille
Copy link
Member Author

@tridelat @zhang-alvin @cekees This is ready to go!

Copy link
Contributor

@zhang-alvin zhang-alvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @JohanMabille

Copy link
Member

@tridelat tridelat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JohanMabille !

@tridelat tridelat merged commit 54d956c into erdc:master Feb 18, 2020
@JohanMabille JohanMabille deleted the cleanup branch February 18, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup import *
3 participants