-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to allow for hotstarting with systemStepExact=False #1236
Conversation
6646e3e
to
a537941
Compare
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
==========================================
- Coverage 52.74% 52.74% -0.01%
==========================================
Files 531 531
Lines 109533 109536 +3
==========================================
Hits 57777 57777
- Misses 51756 51759 +3
Continue to review full report at Codecov.
|
For reference, prior to hack/removal of test, codecov indicated -36% coverage. |
* FIX: hotstart should now work even without systemStepExact * TST: added hotstart test for 2D dambreak case without using systemStepExact * TST: remove numerical comparison for hotstart * HACK: try turning off test to observe codecov behavior * TST: turn back on the hotstart TPF test
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description
Addresses #1235. Not setting the model time prior to proceeding with calculation leads to an infinite loop.
Thanks @cekees for the suggested fix.
Added a test within
tests/TwoPhaseFlow
to test for the fix. Note to keep in mind is that the test is to avoid changes to the infinite loop fix.I tried setting a test to compare numerical results but I believe something along the lines of #1184 was causing a different behavior between the directory-level
pytest
call and amake test
call at the root.