Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RS* signing support #43

Merged
merged 5 commits into from
May 26, 2021
Merged

Add RS* signing support #43

merged 5 commits into from
May 26, 2021

Conversation

letmaik
Copy link
Contributor

@letmaik letmaik commented May 20, 2021

Implements #21.

Some notes:

  • The signing key is passed as PEM string. This could be extended to support DER if a buffer is given. Is this reasonable?
  • I also validated signed messages manually using pycose.

TODO:

  • README?

@coveralls
Copy link

coveralls commented May 20, 2021

Coverage Status

Coverage increased (+0.09%) to 89.912% when pulling 6f8ca48 on letmaik:letmaik/rsa-sign into 3154ca4 on erdtman:master.

@letmaik letmaik marked this pull request as ready for review May 24, 2021 16:33
@letmaik
Copy link
Contributor Author

letmaik commented May 24, 2021

@erdtman The examples submodule doesn't have RS* test cases so I added one in here for now. This can be removed once cose-wg/Examples#105 is done. Let me know if the rest of the PR is fine, happy to make further changes.

@erdtman
Copy link
Owner

erdtman commented May 26, 2021

Looks good to me.
+1 yes it would be nice to put an RSA example in the readme (maybe it is time to create a matrix with what is supported also in the readme file)
love that you have submitted a PR to the cose-wg examples too.

@erdtman erdtman merged commit 92a2b9a into erdtman:master May 26, 2021
@letmaik letmaik deleted the letmaik/rsa-sign branch May 26, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants