Clean compile warnings #395
Merged
+96
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnoam
force-pushed
the
clean_compile_warnings
branch
from
257360d to
c02eaa8
Compare
|
@erebe I've cleaned up this PR and rebased it on top of latest main. I suggest reading it commit by commit (I think it will make more sense that way), but you can read it as a whole just as well. |
|
oh, and i've made sure to run clippy, tests & a basic manual test of the server/client on both macos & linux. |
erebe
reviewed
Jan 7, 2025
|
Only a single comment to see if we can't use |
…ed variables / dead code. unlike so_mark, which was used in many places, these are two isolated cases, so no need to go crazy and define an abstraction
tsnoam
force-pushed
the
clean_compile_warnings
branch
from
c02eaa8 to
f32d93b
Compare
|
thanks @erebe |
|
Thank you ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with so_mark, i went with an abstraction which has no memory footprint nor runtime overhead.
this is because so_mark was used in so many places and I didn't want to add the lint attributes everywhere in the code.
with ip_transparent i chose a more ad-hoc approach, as it was the only one place