Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise extension requirements #1185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Oct 24, 2024

This pull request adds normalisation for ext-* requirements, to match what Composer does internally. I chose to join any collisions with an 'or' separator.

Related to ergebnis/composer-normalize#1388

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.07%. Comparing base (50fda31) to head (b2c0dac).

Files with missing lines Patch % Lines
src/Vendor/Composer/PackageHashNormalizer.php 69.23% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1185      +/-   ##
============================================
- Coverage     96.49%   96.07%   -0.43%     
- Complexity      196      202       +6     
============================================
  Files            32       32              
  Lines           828      841      +13     
============================================
+ Hits            799      808       +9     
- Misses           29       33       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredden fredden force-pushed the feature/normalise-ext-case-and-spaces branch from cac2432 to 021177e Compare November 12, 2024 16:18
@fredden fredden force-pushed the feature/normalise-ext-case-and-spaces branch from 021177e to b2c0dac Compare November 12, 2024 16:29
@fredden fredden marked this pull request as ready for review November 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants