Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for PHP 7.4 #880

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Enhancement: Add support for PHP 7.4 #880

merged 1 commit into from
Dec 1, 2024

Conversation

localheinz
Copy link
Member

This pull request

  • adds support for PHP 7.4

@localheinz localheinz self-assigned this Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (3c69cb8) to head (47fcd1e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Classes/FinalRule.php 0.00% 1 Missing ⚠️
src/Classes/NoExtendsRule.php 0.00% 1 Missing ⚠️
...asses/PHPUnit/Framework/TestCaseWithSuffixRule.php 0.00% 1 Missing ⚠️
...c/Closures/NoNullableReturnTypeDeclarationRule.php 0.00% 1 Missing ⚠️
...c/Closures/NoParameterWithNullDefaultValueRule.php 0.00% 1 Missing ⚠️
...res/NoParameterWithNullableTypeDeclarationRule.php 0.00% 1 Missing ⚠️
src/Expressions/NoCompactRule.php 0.00% 1 Missing ⚠️
src/Files/DeclareStrictTypesRule.php 0.00% 1 Missing ⚠️
.../Functions/NoNullableReturnTypeDeclarationRule.php 0.00% 1 Missing ⚠️
.../Functions/NoParameterWithNullDefaultValueRule.php 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #880   +/-   ##
=========================================
  Coverage     85.52%   85.52%           
  Complexity      208      208           
=========================================
  Files            23       23           
  Lines           739      739           
=========================================
  Hits            632      632           
  Misses          107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz force-pushed the feature/php74 branch 2 times, most recently from 3cd6f55 to b35e010 Compare December 1, 2024 16:35
@localheinz localheinz marked this pull request as ready for review December 1, 2024 16:35
@localheinz localheinz merged commit 38fa87c into main Dec 1, 2024
24 of 25 checks passed
@localheinz localheinz deleted the feature/php74 branch December 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants