Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial debian package support #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

godarklight
Copy link

You'll want to check this one out locally and verify that everything is OK.

I did bump the CMAKE version from 4 to 5 to match the library name to avoid any possible conflict with debian's libmirisdr4 package in their repository, this will break things currently linked against the library, which as far as I know is only SoapyMiri.

I'm happy to make any changes to get this merged, the only issue I can think of is this package currently builds as an 'all' package, but in any case you can install it and it does work.

You do need the debhelper-compat and devscripts package installed, but after that creating a debian package is as simple as cd'ing into the folder and typing 'dpkg-buildpackage', similar to how the entire openwebrx+ project is set up.

@ericek111
Copy link
Owner

Thank you very much. I'm not sure if I want to support Debian and be listed as a maintainer -- I primarily use Arch. I'll test it and merge your PR (also in SoapyMiri) this week. Just one request -- if you could, please, change the e-mail address to [email protected], that'd be appreciated. Thanks again!

@godarklight
Copy link
Author

Updated, I do want to stress the change in the cmake file, it renames the output to '/usr/lib/libmirisdr.so.5' - although I really should fix this so it ends up inside the architecture folder as other packages do, and mark this as a conflict with debians libmirisdr4 package.

debian/control Outdated
Source: libmirisdr5
Section: hamradio
Priority: optional
Maintainer: ericek111 <[email protected]>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly meant here :D Pretty please, could you change it to [email protected], too? Thank you

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops :)

@ericek111
Copy link
Owner

Yes, that's a good idea. While this project is presently backwards API/ABI-compatible with libmirisdr4, it's not guaranteed to stay that way.

@godarklight godarklight force-pushed the master branch 2 times, most recently from 34838d4 to 95002d3 Compare June 25, 2024 10:07
@godarklight
Copy link
Author

I think it's close, it does build fine and correctly marks as a conflict, and also builds as the correct architecture, it is just not in the correct library folder so far. I think I will leave it here today, this will at least give you something to play with if you want to debootstrap yourself a chroot :)

I have tested it on stable and unstable, it builds correctly on both - but let me know if you run into issues.

@godarklight
Copy link
Author

Fixed the other email sorry, will do the same in SoapyMiri now too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants