added min and max validation [Fixes #90] #91
Conversation
| @@ -24,7 +24,7 @@ | |||
| // HTML5-compatible validation pattern library that can be extended and/or overriden. | |||
| patternLibrary : { //** TODO: Test the new regex patterns. Should I apply these to the new input types? | |||
| // **TODO: password | |||
| phone: /([\+][0-9]{1,3}([ \.\-])?)?([\(][0-9]{1,6}[\)])?([0-9A-Za-z \.\-]{1,32})(([A-Za-z \:]{1,11})?[0-9]{1,4}?)/, | |||
| phone: /([\+][0-9]{1,3}([ \.\-])?)?([\(]{1}[0-9]{1,6}[\)])?([0-9A-Za-z \.\-]{1,32})(([A-Za-z \:]{1,11})?[0-9]{1,4}?)/, | |||
|
fixed the comments |
| @@ -154,10 +154,12 @@ | |||
| rangeOverflow: validity.rangeOverflow || false, | |||
| rangeUnderflow: validity.rangeUnderflow || false, | |||
| stepMismatch: validity.stepMismatch || false, | |||
| tooLong: validity.tooLong || false, | |||
| rangeOverflow: validity.rangeOverflow || false, | |||
There was a problem hiding this comment.
These were already here. Now we have duplicates. );
|
Do we have unit tests for this? |
ericelliott
changed the title
|
[#90] |
|
As soon as this pull request has unit tests, I would be more than happy to refactor this into the unified validator model from #87 . It would make it a bit cleaner (the min/max logic would be a little more contained). I definitely love the idea of h5Validate having this capability. |
|
Any progress on this, guys? |
|
I really haven't looked at this since my last comment, but I'm confident that it would fit nicely into the new validator model in #87 . As soon as you've dealt with unified validators one way or another, I can look into this (including perhaps adding some unit tests?). |
|
Honestly, I'm so buried in my current work, it may be a very long time before I have time to deal with it. Would you be interested in becoming the official maintainer of h5Validate? Ideally, every commit will still go through the PR process, and somebody else should at least have the chance to pull down the PR, run the unit tests, and look at the code changes. |
|
Perhaps, or at least maybe just pick up the slack for as long as you're over-committed. |
|
@christianclent Would you be interested in leading a rewrite project? |
No description provided.