reset tests that check for specific values to a category

ericnewton76 · Dec 26, 2017 · da2831d · da2831d
1 parent 0f33d67
commit da2831d
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 2 deletions.
diff --git a/src/Google.Maps.Test/Direction/DirectionServiceTests.cs b/src/Google.Maps.Test/Direction/DirectionServiceTests.cs
@@ -56,7 +56,7 @@ public void Empty_Address_Fails()
 		}
 
 		[Test]
-		[Ignore("currentLeg.Duration value keeps changing")]
+		[Category("ValueTesting")]
 		public void GetResultForDirections_ex1()
 		{
 			// Arrange

diff --git a/src/Google.Maps.Test/Elevation/ElevationServiceTests.cs b/src/Google.Maps.Test/Elevation/ElevationServiceTests.cs
@@ -39,6 +39,15 @@ public void OneTimeSetUp()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
+		public void SHOULD_NOT_RUN()
+		{
+			Console.WriteLine("SHOULD NOT RUN!!!");
+		}
+
+
+		[Test]
+		[Category("ValueTesting")]
 		public void GetElevationForOneLocation()
 		{
 			// expectations
@@ -63,6 +72,7 @@ public void GetElevationForOneLocation()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void GetElevationForTwoLocations()
 		{
 			// expectations

diff --git a/src/Google.Maps.Test/Geocoding/GeocodingRequestTests.cs b/src/Google.Maps.Test/Geocoding/GeocodingRequestTests.cs
@@ -51,6 +51,7 @@ public class GeocodingRequestTests
 		//}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void Implicit_Address_set_from_string()
 		{
 			var req = new GeocodingRequest();
@@ -63,6 +64,7 @@ public void Implicit_Address_set_from_string()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void LatLng_for_address_will_invoke_reverse_geocoding()
 		{
 			var req = new GeocodingRequest();

diff --git a/src/Google.Maps.Test/Geocoding/GeocodingServiceTests.cs b/src/Google.Maps.Test/Geocoding/GeocodingServiceTests.cs
@@ -53,6 +53,7 @@ public void Empty_address()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void GetGeocodingForAddress1()
 		{
 			// Arrange
@@ -81,6 +82,7 @@ public void GetGeocodingForAddress1()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void GetGeocodingForAddress2()
 		{
 			// test
@@ -98,6 +100,7 @@ public void GetGeocodingForAddress2()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void Geocode_With_AddressComponent_Locking()
 		{
 			var requestGB = new GeocodingRequest
@@ -130,6 +133,7 @@ public void Geocode_With_AddressComponent_Locking()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void Geocode_Without_AddressComponent_Locking()
 		{
 			var request = new GeocodingRequest
@@ -146,6 +150,7 @@ public void Geocode_Without_AddressComponent_Locking()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void GeocodeResult_Has_BoundsProperty()
 		{
 			var request = new GeocodingRequest
@@ -162,6 +167,7 @@ public void GeocodeResult_Has_BoundsProperty()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void GeocodeResult_Supports_PostalTownAndPostalCodePrefix()
 		{
 			var request = new GeocodingRequest
@@ -179,6 +185,7 @@ public void GeocodeResult_Supports_PostalTownAndPostalCodePrefix()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void Utf8_Request_And_Response()
 		{
 			var request = new GeocodingRequest

diff --git a/src/Google.Maps.Test/QuickExamplesTests.cs b/src/Google.Maps.Test/QuickExamplesTests.cs
@@ -18,6 +18,7 @@ class QuickExamplesTests
 	{
 
 		[Test]
+		[Category("ValueTesting")]
 		public void GeocodingRequest_Example()
 		{
 			var request = new GeocodingRequest();
@@ -32,6 +33,8 @@ public void GeocodingRequest_Example()
 			Console.WriteLine("Latitude: " + result.Geometry.Location.Latitude);   // 37.4230180
 			Console.WriteLine("Longitude: " + result.Geometry.Location.Longitude); // -122.0818530
 
+			//dont assert on actual values sent from google, these can vary!!!
+
 			Assert.Pass();
 		}
 
@@ -45,10 +48,13 @@ public void StaticMapRequest_Example()
 
 			var imgTagSrc = map.ToUri();
 
-			Assert.Pass();
+			//check program functional outputs, not google's returned values
+
+			Assert.That(imgTagSrc.Query.Contains("zoom=14"));
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void PartialMatchTest()
 		{
 			// invalid address results in partial match

diff --git a/src/Google.Maps.Test/TimeZone/TimeZoneServiceTests.cs b/src/Google.Maps.Test/TimeZone/TimeZoneServiceTests.cs
@@ -39,6 +39,7 @@ public void OneTimeSetUp()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void TimeZoneService_Works_During_DST()
 		{
 			// Arrange
@@ -59,6 +60,7 @@ public void TimeZoneService_Works_During_DST()
 		}
 
 		[Test]
+		[Category("ValueTesting")]
 		public void TimeZoneService_Works_Outside_DST()
 		{
 			// Arrange