Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing calls to test_result() #1799

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add missing calls to test_result() #1799

merged 1 commit into from
Nov 2, 2023

Conversation

serpent7776
Copy link
Contributor

Some tests lack a call to test_result. In effect, these tests could fail without setting nonzero exit code.

brevzin
brevzin approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@brevzin brevzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something something rolling your own test framework...

Thanks for catching this!

@brevzin brevzin merged commit 97452bb into ericniebler:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brevzin brevzin brevzin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serpent7776 @brevzin