Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7702 latest spec update #11585

Merged
merged 20 commits into from
Sep 3, 2024
Merged

7702 latest spec update #11585

merged 20 commits into from
Sep 3, 2024

Conversation

sudeepdino008
Copy link
Member

@sudeepdino008 sudeepdino008 commented Aug 13, 2024 •
edited
Loading

@yperbasis yperbasis added the pectra The Prague/Electra protocol upgrade label Aug 15, 2024
@sudeepdino008 sudeepdino008 marked this pull request as ready for review August 26, 2024 10:03
@sudeepdino008 sudeepdino008 marked this pull request as draft August 26, 2024 10:05
@sudeepdino008 sudeepdino008 marked this pull request as ready for review August 26, 2024 10:33
@sudeepdino008 sudeepdino008 changed the title WIP: 7702 latest spec update 7702 latest spec update Aug 26, 2024
@sudeepdino008 sudeepdino008 requested review from somnathb1, yperbasis and racytech and removed request for somnathb1 August 26, 2024 10:34
yperbasis
yperbasis reviewed Aug 27, 2024
View reviewed changes
core/vm/instructions.go Outdated Show resolved Hide resolved
somnathb1
somnathb1 reviewed Aug 27, 2024
View reviewed changes
core/state_transition.go Show resolved Hide resolved
core/vm/eips.go Outdated Show resolved Hide resolved
@sudeepdino008 sudeepdino008 marked this pull request as draft August 28, 2024 06:19
@sudeepdino008 sudeepdino008 marked this pull request as ready for review August 30, 2024 09:15
@sudeepdino008 sudeepdino008 requested review from somnathb1 and yperbasis and removed request for somnathb1 August 31, 2024 15:16
yperbasis
yperbasis reviewed Sep 2, 2024
View reviewed changes
core/vm/instructions.go Outdated Show resolved Hide resolved
yperbasis
yperbasis reviewed Sep 2, 2024
View reviewed changes
core/vm/evm.go Outdated Show resolved Hide resolved
yperbasis
yperbasis requested changes Sep 2, 2024
View reviewed changes
core/state_transition.go Outdated Show resolved Hide resolved
somnathb1
somnathb1 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@somnathb1 somnathb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intra_block_state can be optimized, other than that lgtm

@sudeepdino008
Copy link
Member Author

intra_block_state can be optimized, other than that lgtm

can you expand on this? I can consider it even if in a later PR.

@somnathb1
Copy link
Contributor

intra_block_state can be optimized, other than that lgtm

can you expand on this? I can consider it even if in a later PR.

For instance, ResolveCode will call GetCode twice if there is no delegation. But that is just nitpicking, you can leave it at this

@sudeepdino008 sudeepdino008 merged commit 54904f5 into main Sep 3, 2024
10 checks passed
@sudeepdino008 sudeepdino008 deleted the 7702_devnet2 branch September 3, 2024 08:40
somnathb1 pushed a commit that referenced this pull request Sep 4, 2024
@sudeepdino008 @somnathb1
7702 latest spec update (#11585)
7181c87 
- implementation for delegated designation and other latest spec changes
- https://eips.ethereum.org/EIPS/eip-7702
- the integration tests updated to latest execution-spec-tests release -
[email protected]
@yperbasis yperbasis mentioned this pull request Oct 3, 2024
Merged
yperbasis added a commit that referenced this pull request Oct 3, 2024
@yperbasis @sudeepdino008
7702 latest spec update (#12198)
eb2a2ff 
Cherry pick #11585

---------

Co-authored-by: sudeep <[email protected]>
AskAlexSharov pushed a commit that referenced this pull request Oct 21, 2024
@yperbasis @sudeepdino008 @AskAlexSharov
7702 latest spec update (#12198)
7108038 
Cherry pick #11585

---------

Co-authored-by: sudeep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yperbasis yperbasis yperbasis approved these changes

@somnathb1 somnathb1 somnathb1 approved these changes

@racytech racytech Awaiting requested review from racytech

Assignees
No one assigned
Labels
pectra The Prague/Electra protocol upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudeepdino008 @somnathb1 @yperbasis