Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block files: idxAvailability must rely on visibleFiles instead of atomics #12078

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

AskAlexSharov
Copy link
Collaborator

reason: visible files guarantee consistency - between file types (because hide under same mutex). maxVisibleBlock atomic - doesn't give such guaranty (mutex doesn't guard them).

for: #12069

@AskAlexSharov AskAlexSharov enabled auto-merge (squash) September 24, 2024 13:48
@AskAlexSharov AskAlexSharov merged commit 2b873ff into main Sep 24, 2024
9 checks passed
@AskAlexSharov AskAlexSharov deleted the assert_same_hight branch September 24, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants