Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten EIP-7685 requests, and requests_root #12210

Closed
wants to merge 21 commits into from
Closed

Flatten EIP-7685 requests, and requests_root #12210

wants to merge 21 commits into from

Conversation

somnathb1
Copy link
Contributor

@somnathb1 somnathb1 commented Oct 3, 2024

Rather than creating a trie and then using the trie root, use the hash of the rlp encoding of the requests list.

Ref1 - ethereum/EIPs#8854 ,
Ref2 - ethereum/EIPs#8907,
Ref3 - ethereum/EIPs#8924

(Tasks board - #12106)

@somnathb1 somnathb1 added the pectra The Prague/Electra protocol upgrade label Oct 3, 2024
@somnathb1
Copy link
Contributor Author

While Ref1 here does say return keccak256(rlp.encode([rlp.encode(req) for req in list])) - I interpret the rlp encoding inside the loop as simply, the rlp encoding of the byte string that is req, and not the un-flattened rlp encoding we used have earlier.

@somnathb1 somnathb1 added the do-not-merge PR that is in a merge-able state but is waiting for something else to take place before merging label Oct 3, 2024
@somnathb1 somnathb1 marked this pull request as draft October 11, 2024 06:47
@somnathb1 somnathb1 changed the title Update EIP-7685 requests root to flat hash Flatten EIP-7685 requests, and requests_root Oct 11, 2024
@somnathb1
Copy link
Contributor Author

Closing in favour of #12337

@somnathb1 somnathb1 closed this Oct 16, 2024
@somnathb1 somnathb1 deleted the pectra4_5 branch November 5, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge PR that is in a merge-able state but is waiting for something else to take place before merging pectra The Prague/Electra protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant