Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu- and macos- "latest" runners, add missed dockerhub login action. #14250

Closed
wants to merge 3 commits into from
Closed

Ubuntu- and macos- "latest" runners, add missed dockerhub login action. #14250

wants to merge 3 commits into from

Conversation

lystopad
Copy link
Member

@lystopad lystopad commented Mar 21, 2025 •
edited
Loading

Requested in #14249

@lystopad
Switch to ubuntu- and macos- "latest" runners,
0cf8b34 
Add missed dockerhub login action.
@lystopad lystopad self-assigned this Mar 21, 2025
@lystopad lystopad marked this pull request as ready for review March 21, 2025 09:17
@lystopad lystopad enabled auto-merge (squash) March 21, 2025 09:51
@taratorio
Copy link
Member

tests-mac-linux was stuck, could not restart manually from CI so did a git pull origin main && git push on the branch to unblock

want to merge this because I saw another docker rate limit issue for our kurtosis job here

@michelemodolo
Copy link
Member

Approving this (I think this PR is much needed as 22.04 is supposed to no longer be available in the backend).

somnathb1
somnathb1 requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@somnathb1 somnathb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main merge doesn't look right

@lystopad lystopad disabled auto-merge March 26, 2025 11:09
@lystopad
Copy link
Member Author

Ok.
I will close this PR and create a new one from latest main branch which should fix all the issues.

Thanks guys for approvals and comments.

@lystopad lystopad closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somnathb1 somnathb1 somnathb1 requested changes

@michelemodolo michelemodolo michelemodolo approved these changes

@taratorio taratorio Awaiting requested review from taratorio

Assignees

@lystopad lystopad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lystopad @taratorio @michelemodolo @somnathb1