Skip to content

Commit

Permalink
CallTest
Browse files Browse the repository at this point in the history
  • Loading branch information
@yperbasis
yperbasis committed Sep 17, 2024
1 parent 2a9cf3d commit 06c6cc4
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions silkworm/infra/grpc/client/call_test.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ struct CallTest : public silkworm::test_util::ContextTestBase {
template <class Stub, class Request, class Response>
Task<Response> check_unary_grpc_threading(
agrpc::detail::ClientUnaryRequest<Stub, Request, ::grpc::ClientAsyncResponseReaderInterface<Response>> rpc,
std::unique_ptr<Stub>& stub,
std::unique_ptr<Stub>& stb,
Request request,
agrpc::GrpcContext& grpc_context) {
const auto this_thread_id{std::this_thread::get_id()};
CHECK(io_context_.get_executor().running_in_this_thread());
const auto response = co_await unary_rpc(rpc, *stub, request, grpc_context);
const auto response = co_await unary_rpc(rpc, *stb, request, grpc_context);
CHECK(io_context_.get_executor().running_in_this_thread());
CHECK(this_thread_id == std::this_thread::get_id());
co_return response;
Expand All @@ -55,7 +55,7 @@ struct CallTest : public silkworm::test_util::ContextTestBase {
//! Same check as above but for agrpc::ClientRPC<>::request, which does not require dispatching to asio::io_context executor
//! because it does guarantee to complete handlers on the calling executor: https://github.com/erigontech/silkrpc/issues/439
Task<::types::VersionReply> check_unary_agrpc_client_threading(
proto::KV::StubInterface& stub,
proto::KV::StubInterface& stb,
google::protobuf::Empty request,
agrpc::GrpcContext& grpc_context) {
::grpc::ClientContext client_context;
Expand All @@ -66,7 +66,7 @@ struct CallTest : public silkworm::test_util::ContextTestBase {
RPC::Response response;
const auto this_thread_id{std::this_thread::get_id()};
CHECK(io_context_.get_executor().running_in_this_thread());
::grpc::Status status = co_await RPC::request(grpc_context, stub, client_context, request, response);
::grpc::Status status = co_await RPC::request(grpc_context, stb, client_context, request, response);
CHECK(io_context_.get_executor().running_in_this_thread());
CHECK(this_thread_id == std::this_thread::get_id());

Expand All @@ -81,7 +81,7 @@ struct CallTest : public silkworm::test_util::ContextTestBase {
using StrictMockKVVersionAsyncResponseReader = rpc::test::StrictMockAsyncResponseReader<::types::VersionReply>;

//! Mocked stub of gRPC KV interface
std::unique_ptr<StrictMockKVStub> stub_{std::make_unique<StrictMockKVStub>()};
std::unique_ptr<StrictMockKVStub> stub{std::make_unique<StrictMockKVStub>()};

//! Mocked reader for Version unary RPC of gRPC KV interface
std::unique_ptr<StrictMockKVVersionAsyncResponseReader> version_reader_ptr{
Expand All @@ -92,34 +92,34 @@ struct CallTest : public silkworm::test_util::ContextTestBase {
TEST_CASE_METHOD(CallTest, "Unary gRPC threading: unary_rpc", "[grpc][client]") {
// Set the call expectations:
// 1. remote::KV::StubInterface::AsyncVersionRaw call succeeds
EXPECT_CALL(*stub_, AsyncVersionRaw).WillOnce(Return(version_reader_ptr.get()));
EXPECT_CALL(*stub, AsyncVersionRaw).WillOnce(Return(version_reader_ptr.get()));
// 2. AsyncResponseReader<types::VersionReply>::Finish call succeeds w/ status OK
EXPECT_CALL(version_reader, Finish).WillOnce(test::finish_ok(grpc_context_));

// Trick necessary because expectations require MockKVStub, whilst production code wants remote::KV::StubInterface
std::unique_ptr<proto::KV::StubInterface> stub{std::move(stub_)};
std::unique_ptr<proto::KV::StubInterface> stub2{std::move(stub)};

// Execute the test: check threading assumptions during async Version RPC execution
spawn_and_wait(check_unary_grpc_threading(&proto::KV::StubInterface::AsyncVersion, stub, google::protobuf::Empty{}, grpc_context_));
spawn_and_wait(check_unary_grpc_threading(&proto::KV::StubInterface::AsyncVersion, stub2, google::protobuf::Empty{}, grpc_context_));
}

TEST_CASE_METHOD(CallTest, "Unary gRPC threading: agrpc::ClientRPC", "[grpc][client]") {
// Set the call expectations:
// 1. remote::KV::StubInterface::PrepareAsyncVersionRaw call succeeds
EXPECT_CALL(*stub_, PrepareAsyncVersionRaw).WillOnce(Return(version_reader_ptr.get()));
EXPECT_CALL(*stub, PrepareAsyncVersionRaw).WillOnce(Return(version_reader_ptr.get()));
// 2. AsyncResponseReader<types::VersionReply>::StartCall call succeeds
EXPECT_CALL(version_reader, StartCall).WillOnce([&]() {});
// 3. AsyncResponseReader<types::VersionReply>::Finish call succeeds w/ status OK
EXPECT_CALL(version_reader, Finish).WillOnce(test::finish_ok(grpc_context_));

// Execute the test: check threading assumptions during async Version RPC execution
spawn_and_wait(check_unary_agrpc_client_threading(*stub_, google::protobuf::Empty{}, grpc_context_));
spawn_and_wait(check_unary_agrpc_client_threading(*stub, google::protobuf::Empty{}, grpc_context_));
}

TEST_CASE_METHOD(CallTest, "Unary gRPC cancelling: unary_rpc", "[grpc][client]") {
// Set the call expectations:
// 1. remote::KV::StubInterface::AsyncVersionRaw call succeeds
EXPECT_CALL(*stub_, AsyncVersionRaw).WillOnce(Return(version_reader_ptr.get()));
EXPECT_CALL(*stub, AsyncVersionRaw).WillOnce(Return(version_reader_ptr.get()));
// 2. AsyncResponseReader<types::VersionReply>::Finish call fails w/ status CANCELLED
boost::asio::cancellation_signal cancellation_signal;
auto cancellation_slot = cancellation_signal.slot();
Expand All @@ -133,11 +133,11 @@ TEST_CASE_METHOD(CallTest, "Unary gRPC cancelling: unary_rpc", "[grpc][client]")
});

// Trick necessary because expectations require MockKVStub, whilst production code wants remote::KV::StubInterface
std::unique_ptr<proto::KV::StubInterface> stub{std::move(stub_)};
std::unique_ptr<proto::KV::StubInterface> stub2{std::move(stub)};

// Execute the test: start and then cancel async Version RPC execution
auto version_reply = spawn(unary_rpc(&proto::KV::StubInterface::AsyncVersion,
*stub,
*stub2,
google::protobuf::Empty{},
grpc_context_,
&cancellation_slot));
Expand Down

0 comments on commit 06c6cc4

Please sign in to comment.