rpcdaemon: fix serialization of "to" field as JSON null in Receipt (#…

…1443)
erigontech · Aug 11, 2023 · 8d95690 · 8d95690
1 parent ad13f74
commit 8d95690
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/silkworm/silkrpc/json/receipt.cpp b/silkworm/silkrpc/json/receipt.cpp
@@ -18,7 +18,6 @@
 
 #include <silkworm/core/common/util.hpp>
 #include <silkworm/infra/common/log.hpp>
-#include <silkworm/silkrpc/common/compatibility.hpp>
 #include <silkworm/silkrpc/common/util.hpp>
 
 #include "types.hpp"
@@ -31,15 +30,10 @@ void to_json(nlohmann::json& json, const Receipt& receipt) {
     json["transactionHash"] = receipt.tx_hash;
     json["transactionIndex"] = to_quantity(receipt.tx_index);
     json["from"] = receipt.from.value_or(evmc::address{});
-    // Erigon currently at 2.48.1 returns zero address if to field is missing
-    if (compatibility::is_erigon_json_api_compatibility_required()) {
-        json["to"] = receipt.to.value_or(evmc::address{});
+    if (receipt.to) {
+        json["to"] = *receipt.to;
     } else {
-        if (receipt.to) {
-            json["to"] = *receipt.to;
-        } else {
-            json["to"] = nlohmann::json{};
-        }
+        json["to"] = nlohmann::json{};
     }
     json["type"] = to_quantity(receipt.type ? receipt.type.value() : 0);
     json["gasUsed"] = to_quantity(receipt.gas_used);