fix more warnings

erigontech · Jan 24, 2024 · d1c3741 · d1c3741
1 parent abae26f
commit d1c3741
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/silkworm/node/stagedsync/execution_engine.cpp b/silkworm/node/stagedsync/execution_engine.cpp
@@ -20,7 +20,6 @@
 
 #include <silkworm/infra/common/ensure.hpp>
 #include <silkworm/node/db/access_layer.hpp>
-#include <silkworm/node/db/db_utils.hpp>
 
 namespace silkworm::stagedsync {
 
@@ -29,7 +28,7 @@ using namespace boost::asio;
 ExecutionEngine::ExecutionEngine(asio::io_context& ctx, NodeSettings& ns, db::RWAccess dba)
     : io_context_{ctx},
       node_settings_{ns},
-      main_chain_(ctx, ns, dba),
+      main_chain_{ctx, ns, std::move(dba)},
       block_cache_{kDefaultCacheSize} {}
 
 void ExecutionEngine::open() {  // needed to circumvent mdbx threading model limitations

diff --git a/silkworm/node/stagedsync/forks/main_chain.cpp b/silkworm/node/stagedsync/forks/main_chain.cpp
@@ -32,10 +32,10 @@ namespace silkworm::stagedsync {
 //! The number of inserted blocks between two successive commits on db
 constexpr uint64_t kInsertedBlockBatch{1'000};
 
-MainChain::MainChain(boost::asio::io_context& ctx, NodeSettings& ns, const db::RWAccess dba)
+MainChain::MainChain(boost::asio::io_context& ctx, NodeSettings& ns, db::RWAccess dba)
     : io_context_{ctx},
       node_settings_{ns},
-      db_access_{dba},
+      db_access_{std::move(dba)},
       tx_{db_access_.start_rw_tx()},
       data_model_{tx_},
       pipeline_{&ns},

diff --git a/silkworm/node/stagedsync/server.cpp b/silkworm/node/stagedsync/server.cpp
@@ -25,8 +25,7 @@ namespace silkworm::execution {
 using namespace std::chrono;
 namespace asio = boost::asio;
 
-Server::Server(NodeSettings& ns, db::RWAccess dba) : exec_engine_{io_context_, ns, dba} {
-}
+Server::Server(NodeSettings& ns, db::RWAccess dba) : exec_engine_{io_context_, ns, std::move(dba)} {}
 
 bool Server::stop() {
     io_context_.stop();