Address cert-oop54-cpp warning

erigontech · Jan 16, 2024 · d850710 · d850710
1 parent d24299d
commit d850710
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/.clang-tidy b/.clang-tidy
@@ -12,7 +12,6 @@ Checks: >
   -bugprone-unused-raii,
   cert-*,
   -cert-err58-cpp,
-  -cert-oop54-cpp,
   -clang-analyzer-*,
   clang-diagnostic-*,
   concurrency-*,

diff --git a/silkworm/core/common/small_map.hpp b/silkworm/core/common/small_map.hpp
@@ -59,6 +59,9 @@ class SmallMap {
         }
     }
     constexpr SmallMap& operator=(const SmallMap& other) {
+        if (this == &other) {
+            return *this;
+        }
         size_ = other.size_;
         for (size_t i{0}; i < max_size; ++i) {
             data_[i] = other.data_[i];

diff --git a/silkworm/core/concurrency/resettable_once_flag.hpp b/silkworm/core/concurrency/resettable_once_flag.hpp
@@ -45,6 +45,9 @@ class ResettableOnceFlag {
         }
     }
     ResettableOnceFlag& operator=(const ResettableOnceFlag& other) {
+        if (this == &other) {
+            return *this;
+        }
         const uint32_t other_flag{other.flag_.load(std::memory_order_acquire)};
         if (other_flag == absl::base_internal::kOnceDone) {
             flag_.store(absl::base_internal::kOnceDone, std::memory_order_release);