Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: treat clang-tidy warnings as errors #1740

Merged
merged 3 commits into from
Jan 8, 2024
Merged

sync: treat clang-tidy warnings as errors #1740

merged 3 commits into from
Jan 8, 2024

Conversation

yperbasis
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (43f818f) 52.68% compared to head (744abb7) 52.66%.
Report is 1 commits behind head on master.

Files Patch % Lines
silkworm/sync/block_exchange.cpp 0.00% 6 Missing ⚠️
silkworm/sync/internals/statistics.cpp 0.00% 4 Missing ⚠️
silkworm/sync/messages/outbound_new_block.cpp 0.00% 2 Missing ⚠️
silkworm/sync/sentry_client.cpp 0.00% 2 Missing ⚠️
silkworm/sync/internals/header_chain.cpp 94.44% 1 Missing ⚠️
...lkworm/sync/messages/outbound_new_block_hashes.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1740      +/-   ##
==========================================
- Coverage   52.68%   52.66%   -0.03%     
==========================================
  Files         596      596              
  Lines       44508    44503       -5     
  Branches     6882     6881       -1     
==========================================
- Hits        23449    23437      -12     
+ Misses      19014    19013       -1     
- Partials     2045     2053       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yperbasis yperbasis marked this pull request as ready for review January 8, 2024 09:58
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jan 8, 2024
@canepat canepat merged commit ef35532 into master Jan 8, 2024
13 checks passed
@canepat canepat deleted the ci/tidier7 branch January 8, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants